tox: drop non-working Python 3.6 from tox tests#1661
Merged
FrostyX merged 1 commit intorpm-software-management:mainfrom Dec 1, 2025
Merged
tox: drop non-working Python 3.6 from tox tests#1661FrostyX merged 1 commit intorpm-software-management:mainfrom
FrostyX merged 1 commit intorpm-software-management:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes Python 3.6 from the tox test environments, and the change in tox.ini is accurate. As a follow-up, I recommend simplifying mock/requirements.txt. Since Python < 3.9 is no longer tested, the conditional dependency on pyroute2 can be made unconditional, which would improve maintainability by replacing pyroute2==0.5.3; python_version < "3.9" and pyroute2; python_version >= "3.9" with just pyroute2.
We no longer support Mock on RHEL 7 (`main` branch) anyway. RHEL 8 runs on Python 3.9.
praiskup
force-pushed
the
praiskup-fix-tox
branch
from
ba7840b to
cbef26f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer support Mock on RHEL 7 (
mainbranch) anyway. RHEL 8 runs on Python 3.9.